Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the major breaking change in 4.3.10 #455

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Revert the major breaking change in 4.3.10 #455

merged 1 commit into from
Aug 31, 2021

Conversation

alexanderbh
Copy link
Contributor

@alexanderbh alexanderbh commented Aug 30, 2021

Description of changes:
Revert to the old behavior of just routing on the proxy part.

4.3.10 is a major breaking change for existing users depending on the current behavior.

@selvendranayyaswamy
@selvendran.ayyaswamy

Checklist

  • Tests have been added and are passing
  • Documentation has been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Revert to the old behavior of just routing on the proxy part.

4.3.10 is a major breaking change for existing users depending on the current behavior.

This will fix #454
@brett-vendia
Copy link
Contributor

Sorry about that, I thought we had tests that covered this. I'll look into fixing the other issue and adding tests. Thanks!

@brett-vendia brett-vendia merged commit 87aa26f into CodeGenieApp:mainline Aug 31, 2021
github-actions bot pushed a commit that referenced this pull request Aug 31, 2021
## [4.3.11](v4.3.10...v4.3.11) (2021-08-31)

### Bug Fixes

* revert [#441](#441) ([#455](#455)) ([87aa26f](87aa26f)), closes [#454](#454)
@github-actions
Copy link

🎉 This PR is included in version 4.3.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexanderbh alexanderbh deleted the patch-1 branch September 1, 2021 05:32
OneDev0411 added a commit to OneDev0411/serverless-express that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants