Add xo as a linting tool
#64
Conversation
|
Looks great! But I think the |
| return n; | ||
| return n | ||
| default: | ||
| return undefined |
There was a problem hiding this comment.
I had to add a default case, which keeps the current behavior, but you might want to add a different behavior somehow (return NaN or something?)
There was a problem hiding this comment.
Why should we add a different behavior (instead of returning undefined)?
There was a problem hiding this comment.
After reviewing the code a bit more, I don't think you should. Maybe you wanted to always return a string, but the function already returns undefined in some cases, so this should be fine.
It was more of a "Hey, you may have forgotten this case" reminder. The linter warned me of it, and I wanted to warn you too, before this warning gets lost forever ;)
There was a problem hiding this comment.
Got it! Let's keep this for now.
|
Sorry, forgot to mention that. I'm fine with adding the |
|
@jfmengels Ahhh, you're right. We're not transpiring anything atm, so we also shouldn't add the property! |
|
Will probably do a few more repos later today/this week-end. Let me know if you need help for the |
|
@jfmengels Cool, thanks! 😊 Yea, I definitely need help there... What's the best way to handle that? Can you copy my branch and work from there? |
|
Oh, we also need the badge! 😄 |
Sure, I'll try that. And you're right, forgot the badge. Will make PRs for that ;) |
|
@jfmengels Perfect! I already added the badge to async-throttle and ms 😊 |
This adds XO as a linting tool to have a consistent linter and style accross the Zeit projects, as requested by @leo.