Add fetchpriority="high" when next/image has priority prop 📷
#43096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaiyan-dev
requested review from
timneutkens,
ijjk,
shuding and
styfle
as code owners
|
Updated version of #40887 |
ijjk
force-pushed
the
canary
branch
2 times, most recently
from
e078ebe
to
6b863fe
Compare
|
Extremely sorry please teach me to resolve merge conflict. |
styfle
reviewed
Dec 14, 2022
packages/next/client/image.tsx
Outdated
| @@ -355,6 +355,64 @@ function handleLoading( | |||
| }) | |||
| } | |||
|
|
|||
| sanjaiyan-image-loading-priority | |||
styfle
reviewed
Dec 22, 2022
| height={heightInt} | ||
| decoding="async" | ||
| // https://web.dev/priority-hints/#increase-the-priority-of-the-lcp-image | ||
| fetchPriority={priority ? "high" : rest.fetchPriority} |
There was a problem hiding this comment.
This will print an warning with React
ijjk
pushed a commit
that referenced
this pull request
Mar 17, 2023
- Closes #43096 - Available since Chrome 101: https://chromestatus.com/feature/5273474901737472 - Coming to Safari: https://bugs.webkit.org/show_bug.cgi?id=252739 - Introduction blog: https://web.dev/priority-hints/ fix NEXT-319 ([link](https://linear.app/vercel/issue/NEXT-319))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
fetchpriority="high"according topriorityprop.Inspired from Angular Image component.
Sorry if I made any mistakes :(