Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-swc): reenable filesystem cache #50651

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jun 1, 2023

What?

Quick fix for the regressions that next.js cannot load plugin due to missing filesystem cache.

@kwonoj kwonoj enabled auto-merge (squash) June 2, 2023 06:25
@huozhi huozhi disabled auto-merge June 2, 2023 14:28
@ijjk
Copy link
Member

ijjk commented Jun 2, 2023

Failing test suites

Commit: 19222bb

pnpm testheadless test/integration/telemetry/test/page-features.test.js

  • page features telemetry > detects reportWebVitals with no _app correctly for next build
Expand output

● page features telemetry › detects reportWebVitals with no _app correctly for next build

TypeError: Cannot read properties of null (reading 'pop')

  234 |
  235 |     let event1 = /NEXT_BUILD_OPTIMIZED[\s\S]+?{([\s\S]+?)}/
> 236 |       .exec(build.stderr)
      |                   ^
  237 |       .pop()
  238 |     expect(event1).toMatch(/hasReportWebVitals.*?false/)
  239 |   })

  at Object.<anonymous> (integration/telemetry/test/page-features.test.js:236:19)

Read more about building and testing Next.js in contributing.md.

@kodiakhq kodiakhq bot merged commit 78ed08d into canary Jun 5, 2023
@kodiakhq kodiakhq bot deleted the fix-filesystem-cache branch June 5, 2023 15:42
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
### What?

Quick fix for the regressions that next.js cannot load plugin due to missing filesystem cache.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants