-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @datadog/pprof
#410
Comments
Is there any progress at all? We have same issue |
The PR is up awaiting review. You could comment there just to nudge it towards getting merged |
styfle
added a commit
that referenced
this issue
May 16, 2024
- Fixes #410 - Closes #411 Note, this is easiest to review without whitespace https:/vercel/nft/pull/419/files?w=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When building with
output: standalone
,@datadog/pprof
prebuilds
gets excluded as the current AST logic introduced in #391 does not handle the case where imports are assigned to a const.See
@datadog/pprof
codebase here on how they assign the CJS import ofnode-gyp-build
to a variable, that way we cannot resolve the name tonode-gyp-build
just by inferring the AST node's first argumentSuggested solution
Instead of modifying the conditionals to handle this case like in #391, just add a special case for
@datadog/pprof
to include theprebuilds
folder. I have a fix up and will discuss the alternative in more detail hereThe text was updated successfully, but these errors were encountered: