chore(test): Remove windows-specific prepare-install
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsee55
changed the title
prepare-install
jeffsee55
changed the title
prepare-installprepare-install
TooTallNate
reviewed
Jul 3, 2024
TooTallNate
approved these changes
Jul 3, 2024
Co-authored-by: Nathan Rajlich <[email protected]>
styfle
approved these changes
Jul 3, 2024
styfle
changed the title
prepare-installprepare-install
styfle
changed the title
prepare-installprepare-install
|
🎉 This PR is included in version 0.27.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a need to skip some integration tests for Windows, this PR moves the logic for skipping to the test setup itself rather than altering the tests and dependencies as we were doing in the
prepare-installstep. The pre-install logic was also deleting thepackage-lock.json, I'm not 100% clear on what the purpose was, but seems like it may have been done accidentally given the context of the diff here.With the previous logic, CI started to fail on Windows because the
package-lock.jsonwas removed before install, causing us to install a later version of dependency. Instead of removing that line of code in theprepare-installfile, just trying this approach which feels a little more straightforward.