Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

fs-extra v10 is broken with pkg. #1180

Closed
jesec opened this issue May 18, 2021 · 4 comments · Fixed by #1173
Closed

fs-extra v10 is broken with pkg. #1180

jesec opened this issue May 18, 2021 · 4 comments · Fixed by #1173
Assignees

Comments

@jesec
Copy link
Contributor

jesec commented May 18, 2021

fs-extra released v10 and now it's broken with pkg. Here's the error I'm seeing:

TypeError: Cannot read property 'name' of undefined
    at /snapshot/project/node_modules/universalify/index.js:15:26
    at Object.<anonymous> (/snapshot/project/node_modules/fs-extra/lib/fs/index.js:57:27)
    at Module._compile (pkg/prelude/bootstrap.js:1503:22)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at Module.require (pkg/prelude/bootstrap.js:1409:31)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/snapshot/project/node_modules/fs-extra/lib/index.js:5:6)

Using fs-extra@9 doesn't have this problem.

Originally posted by @fcastilloec in #850 (comment)

@jesec jesec self-assigned this May 18, 2021
@jesec
Copy link
Contributor Author

jesec commented May 18, 2021

cc: @robertsLando @erossignon

This is an urgent issue.

@jesec
Copy link
Contributor Author

jesec commented May 18, 2021

I took a second look. Apparently #1173 is related to fs-extra, but we haven't released a new version yet.

@jesec jesec linked a pull request May 18, 2021 that will close this issue
@jesec
Copy link
Contributor Author

jesec commented May 18, 2021

Can not reproduce on master branch. Presumptively already resolved by #1173.

@leerob We should release 5.2, after we bump pkg-fetch to 3.1.0.

Alternatively we can cherry-pick #1173 to 5.1.0, and do a 5.1.1.

@jesec jesec assigned leerob and unassigned jesec May 18, 2021
@robertsLando
Copy link
Contributor

Yeah I think that problem is already resolved by #1173

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@leerob @robertsLando @jesec and others