-
Notifications
You must be signed in to change notification settings - Fork 1k
Packaged apps crash with zero messaging when NODE_OPTIONS is set #1517
Comments
I can add that an app packaged with |
Hey @robertsLando, thanks for the help. Apologies for missing the comment until now. I switched to the regular JavaScript version of |
@gluxon I said that because when you try to run a packaged app from vscode terminal it will not work, dunno the reason but I think it's because vscode has some env var that cause it to crash |
We observed this issue today as well with pkg 5.3.3 wrapping Node 16 for a Ubuntu 20.04 host. |
Production binaries shall NOT take NODE_OPTIONS from end-users. Only the users (developers who use pkg to package their project) should have control over the flags via the "bake in" (--options) mechanism. Bug: vercel/pkg#954, vercel/pkg#989, vercel/pkg#1194, vercel/pkg#1517
Production binaries shall NOT take NODE_OPTIONS from end-users. Only the users (developers who use pkg to package their project) should have control over the flags via the "bake in" (--options) mechanism. Bug: vercel/pkg#954, vercel/pkg#989, vercel/pkg#1194, vercel/pkg#1517
Production binaries shall NOT take NODE_OPTIONS from end-users. Only the users (developers who use pkg to package their project) should have control over the flags via the "bake in" (--options) mechanism. Bug: vercel/pkg#954, vercel/pkg#989, vercel/pkg#1194, vercel/pkg#1517
Hey @robertsLando, I was looking over this issue again and I realized I forgot to respond. Although VS Code is setting an environment variable that causes it to crash (i.e It looks like vercel/pkg-fetch@52d32ed may fix the problem though. Going to check and close this issue if so. |
Confirmed that |
What version of pkg are you using?
5.5.2
What version of Node.js are you using?
v17.5.0
What operating system are you using?
macOS, Ubuntu 20.04.3
What CPU architecture are you using?
x86_64
What Node versions, OSs and CPU architectures are you building for?
node14-linux-x64, node14-macos-x64
Describe the Bug
Hi, this is a duplicate of #484. It doesn't look like the community can re-open issues, so I'd like to create a new issue to get visibility from the team on a serious vercel/pkg bug.
#484 (comment)
We're seeing this over in the pnpm repo: pnpm/pnpm#4319. Thanks in advance for any help.
@BlackHole1 compiled a list of existing closed issues. Copying for visibility.
Expected Behavior
A warning for mismatched
NODE_OPTIONS
flags is printed.To Reproduce
I'm using the
pnpm
binary as an example, but I believe this will happen for anypkg
binary from looking over previous tickets.The text was updated successfully, but these errors were encountered: