Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Zip executables ? #885

Closed
chichke opened this issue Apr 7, 2020 · 7 comments · Fixed by #1115
Closed

Zip executables ? #885

chichke opened this issue Apr 7, 2020 · 7 comments · Fixed by #1115
Assignees

Comments

@chichke
Copy link

chichke commented Apr 7, 2020

Can we have an option like --zip to compress executables as soon as they are built 🤔

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

@erossignon
Copy link
Contributor

Instead of compressing the exectuable, we could at least compress the files inside the embedded virtual file system.

@robertsLando
Copy link
Contributor

@erossignon This is interesting, any idea about how to do this?

erossignon added a commit to node-opcua/pkg that referenced this issue Mar 31, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Mar 31, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Mar 31, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 1, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 2, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 7, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 7, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 7, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 8, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 8, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 11, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 22, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 23, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 24, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 24, 2021
erossignon added a commit to node-opcua/pkg that referenced this issue Apr 24, 2021
@sayem314
Copy link

This is how to archive with pkg.
https://notabug.org/sayem314/d-fi/src/3e07f3fa8b0851f761c62ff4da4229e0b732f211/build.sh

sayem@pop-os:~/workflow/d-fi/d-fi$ ./build.sh
+ rm -rf build
+ rm -rf dist
+ yarn build
yarn run v1.22.5
$ eslint .
$ tsc
Done in 3.80s.
+ pkg --out-path build package.json --targets node14-linux-x64,node14-alpine-x64,node14-win-x64,node14-macos-x64
> [email protected]
+ cd build
+ for file in *
+ du -sh d-fi-alpine
47M	d-fi-alpine
+ [[ d-fi-alpine == *\.\e\x\e* ]]
+ mv d-fi-alpine d-fi
+ zip d-fi-alpine.zip d-fi
  adding: d-fi (deflated 63%)
+ rm d-fi
+ for file in *
+ du -sh d-fi-linux
42M	d-fi-linux
+ [[ d-fi-linux == *\.\e\x\e* ]]
+ mv d-fi-linux d-fi
+ zip d-fi-linux.zip d-fi
  adding: d-fi (deflated 62%)
+ rm d-fi
+ for file in *
+ du -sh d-fi-macos
38M	d-fi-macos
+ [[ d-fi-macos == *\.\e\x\e* ]]
+ mv d-fi-macos d-fi
+ zip d-fi-macos.zip d-fi
  adding: d-fi (deflated 66%)
+ rm d-fi
+ for file in *
+ du -sh d-fi-win.exe
36M	d-fi-win.exe
+ [[ d-fi-win.exe == *\.\e\x\e* ]]
+ mv d-fi-win.exe d-fi.exe
+ zip d-fi-win.zip d-fi.exe
  adding: d-fi.exe (deflated 62%)
+ rm d-fi.exe
+ du -sh d-fi-alpine.zip d-fi-linux.zip d-fi-macos.zip d-fi-win.zip
18M	d-fi-alpine.zip
16M	d-fi-linux.zip
13M	d-fi-macos.zip
14M	d-fi-win.zip

@robertsLando
Copy link
Contributor

that will just add the files to an archive, doesn't make the archive executable

@sayem314
Copy link

@robertsLando oh I'm sorry. I think I misunderstood the issue.

@chichke
Copy link
Author

chichke commented Jun 17, 2021

Thanks for all the work put into this feature 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants