Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Add docs for automatic releases w. GitHub Actions #1246

Closed
wants to merge 1 commit into from
Closed

Add docs for automatic releases w. GitHub Actions #1246

wants to merge 1 commit into from

Conversation

karlhorky
Copy link

@karlhorky karlhorky commented Jul 4, 2021

Hi there, thanks for pkg, really amazing!

Wanted to test the waters on documenting usage of GitHub actions to automate building using pkg and uploading the executables as assets to a GitHub release.

Example here:

@jesec
Copy link
Contributor

jesec commented Jul 6, 2021

Thanks for the contribution. It is a very good tutorial.

Unfortunately, it would be inappropriate for us to endorse a specific CI service.

Additionally, naturally people assume that project maintainers provide support to contents in README of the project. However, we do not have the capacity to support Github Actions, and we will not be able to answer everyone's (in our view, out-of-scope) "how to automate my workflow" questions.

In fact, there are many other ways to integrate pkg with the workflow of the project. A way that does not tie to a specific CI provider is to simply add a build-pkg command to package.json, so anyone (incl. any CI provider one may choose) can run npm run build-pkg to build the pkg executables.

@jesec jesec closed this Jul 6, 2021
@karlhorky
Copy link
Author

Ah ok, would it be accepted if there were examples for other CI platforms? Also with a disclaimer that there is no support provided for this?

The value that I see is in the ability of copy + pasting this without having to research the different parts and how to plug them together (which can take hours)

@karlhorky karlhorky deleted the patch-1 branch July 6, 2021 11:59
@karlhorky karlhorky restored the patch-1 branch July 6, 2021 11:59
@karlhorky karlhorky deleted the patch-1 branch July 6, 2021 11:59
@jesec
Copy link
Contributor

jesec commented Jul 6, 2021

Ah ok, would it be accepted if there were examples for other CI platforms? Also with a disclaimer that there is no support provided for this?

The value that I see is in the ability of copy + pasting this without having to research the different parts and how to plug them together (which can take hours)

That kinda makes things worse, and we are now expected to provide support to not only Github Actions but also others.

Well. We all know that people don't read disclaimer. ;)

If things are in README, we are expected to provide (some degree of) support. I do not believe that we should do that, and we don't have resources for that. "How to automate your workflow" is quite out-of-scope for this project.

@karlhorky
Copy link
Author

karlhorky commented Jul 6, 2021

Ok, then how about an examples or recipes folder, à la Next.js? Those are very clearly maintained by community members.

Then the readme could link to this examples folder...

@jesec
Copy link
Contributor

jesec commented Jul 6, 2021

Ok, then how about an examples or recipes folder, à la Next.js? Those are very clearly maintained by community members.

Then the readme could link to this examples folder...

That would be a bit more acceptable.

Keep in mind that Next.js is the main product and is maintained by a team of dedicated engineers. This project is not allocated the same level of resources and is mostly maintained in voluntary capacity.

I believe that such out-of-scope tutorials/examples do not necessarily justify the maintenance burden, as a result.

@karlhorky
Copy link
Author

Ok, would such a PR be accepted? If not, then we can just leave it at that.

@jesec
Copy link
Contributor

jesec commented Jul 6, 2021

Ok, would such a PR be accepted? If not, then we can just leave it at that.

Unfortunately, no.

@azerpas
Copy link

azerpas commented Feb 18, 2022

Hi there, thanks for pkg, really amazing!

Wanted to test the waters on documenting usage of GitHub actions to automate building using pkg and uploading the executables as assets to a GitHub release.

Example here:

Great example, thanks!

@karlhorky
Copy link
Author

@azerpas glad that it helped you!

Since it unfortunately won't be accepted here, I have published a separate repo with the guide: https:/karlhorky/vercel-pkg-github-actions-release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants