This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
fix: missing entrypoint when launched from self-created child process #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
previously requested changes
Jun 20, 2023
I added one. I also changed the actual fix a little bit to make sure it really only is a fallback for the case that |
robertsLando
changed the title
How would I do that? I ran |
|
The error is shown here: https:/vercel/pkg/actions/runs/5321783982/jobs/9638103625?pr=1949#step:6:19 Try using |
|
Got it. Fixed. |
robertsLando
approved these changes
Jun 21, 2023
pcnate
pushed a commit
to pcnate/pkg
that referenced
this pull request
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that occurs when a packaged executable (Windows 11) is launched from a child process which was created by the executable itself (like for a self updating executable). This bug was reported already in #1861.
It seems that there is a conditional block at the start of
bootstrap.jswhich has the potential to causeENTRYPOINTto becomeundefined. I have to admit that I don't understand the purpose of the that specific code block, but I understand as much as that there always needs to be an entrypoint to successfully launch the executable. So I simply added anelsestatement as a fall back to theDEFAULT_ENTRYPOINT.