Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove headers #45

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Allow to remove headers #45

merged 1 commit into from
Aug 21, 2018

Conversation

wellingguzman
Copy link
Contributor

This creates the opportunity to delete any header when the value is null.

Example below will remove the default Content-Disposition:

{
  "headers": [
    {
      "source" : "**/*.*",
      "headers" : [{
        "key" : "Content-Disposition",
        "value" : null
      }]
    }]
}

Ref: vercel/serve#438

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         305    309    +4     
=====================================
+ Hits          305    309    +4
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d934514...afde1e1. Read the comment docs.

@leo leo merged commit 6e78032 into vercel:master Aug 21, 2018
@leo
Copy link
Contributor

leo commented Aug 21, 2018

Thanks!

@wellingguzman wellingguzman deleted the patch1 branch August 23, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants