Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors thrown in createReadStream properly #56

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Handle errors thrown in createReadStream properly #56

merged 2 commits into from
Sep 4, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented Sep 4, 2018

After this PR, any error thrown from inside createReadStream results in a 500 response.

@leo leo added the enhancement New feature or request label Sep 4, 2018
@leo leo requested review from timneutkens, jamo and TooTallNate and removed request for timneutkens September 4, 2018 17:17
@leo leo removed the request for review from jamo September 4, 2018 17:25
@leo leo merged commit fcd2815 into master Sep 4, 2018
@leo leo deleted the fix branch September 4, 2018 17:25
@leo leo mentioned this pull request Sep 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo @TooTallNate