Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal mjs/mts references as well #5458

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

alexkirsz
Copy link
Contributor

Description

In #5457, I fixed internal .jsx?/.tsx? references not being processed. However, it turns out we also use .mjs for structured images in Next.js, which also use internal references.

Testing Instructions

Next.js CI

@alexkirsz alexkirsz requested a review from a team as a code owner July 4, 2023 13:45
@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-cra-web ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-native-web ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-svelte-web ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
examples-vite-web ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm
turbo-site ⬜️ Ignored (Inspect) Jul 4, 2023 1:45pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Linux Benchmark for 88fc2fc

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 11.70ms ± 0.06ms 11.69ms ± 0.11ms -0.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 10.91ms ± 0.07ms 11.27ms ± 0.31ms +3.25%
bench_startup/Turbopack CSR/1000 modules 1165.58ms ± 2.04ms 1174.80ms ± 8.13ms +0.79%

@alexkirsz alexkirsz merged commit c9868f7 into main Jul 4, 2023
@alexkirsz alexkirsz deleted the alexkirsz/web-866-fix-internal-js branch July 4, 2023 14:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

MacOS Benchmark for 88fc2fc

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 14.16s ± 2.52s 3505.39ms ± 65.93ms -75.24% -60.13%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 28.53ms ± 0.25ms 28.06ms ± 0.09ms -1.66%
bench_hmr_to_eval/Turbopack CSR/1000 modules 27.01ms ± 0.14ms 27.25ms ± 0.11ms +0.89%
bench_startup/Turbopack CSR/1000 modules 14.16s ± 2.52s 3505.39ms ± 65.93ms -75.24% -60.13%

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jul 4, 2023
shuding pushed a commit to vercel/next.js that referenced this pull request Jul 8, 2023
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

In #5457, I fixed internal .jsx?/.tsx? references not being processed.
However, it turns out we also use `.mjs` for structured images in
Next.js, which also use internal references.

### Testing Instructions

Next.js CI
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

In #5457, I fixed internal .jsx?/.tsx? references not being processed.
However, it turns out we also use `.mjs` for structured images in
Next.js, which also use internal references.

### Testing Instructions

Next.js CI
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

In #5457, I fixed internal .jsx?/.tsx? references not being processed.
However, it turns out we also use `.mjs` for structured images in
Next.js, which also use internal references.

### Testing Instructions

Next.js CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants