feat: allow for specifying path of root turbo.json #9087
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
| let config = sources.into_iter().try_fold( | ||
| ConfigurationOptions::default(), | ||
| |mut acc, current_source| { | ||
| let mut current_source_config = current_source.get_configuration_options(&acc)?; |
There was a problem hiding this comment.
There was an existing bug where we would ignore any errors that came from resolving config options from a source. In reality since these were (mostly) eagerly calculated it only affected and validation errors from extracting config options from a turbo.json.
We now bubble up any errors generated by resolving config options.
| if !self.enabled { | ||
| return None; | ||
| } | ||
| let trace_json_path = self.repo_root.join_components(&TASK_ACCESS_CONFIG_PATH); |
There was a problem hiding this comment.
In the original code, we first resolve the dir arg then join to TASK_ACCESS_CONFIG_PATH. Do we no longer need the dir part?
There was a problem hiding this comment.
We do not need to as traced turbo.json is only supported for single package repositories so it would only be successful for dir == "" where it ends up being at $REPO_ROOT/.turbo/traced-config.json
There was a problem hiding this comment.
Not required in this PR we can fix this when we need it but this should be aware of the cache dir as well beacuse the intention is that the config gets cached as an artifact.
Co-authored-by: Nicholas Yang <[email protected]>
chris-olszewski
deleted the
chrisolszewski/turbo-4008-investigate-viability-of-a-config-path-or-similar-flag
branch
Description
Allow for setting the root
turbo.jsonpath via--root-turbo-json=path/to/my.jsonorTURBO_ROOT_TURBO_JSON=path/to/my.json. This option is not compatible with watch mode.Reviewing this PR should be done commit-wise, there's a lot of prefactoring before the final commit that implements the actual feature.
Major changes as part of prefactor:
turbo.jsonbased on absolute paths instead of repo root relative ones. This allows us to read aturbo.jsonfrom wherever a user wantsturbo.jsonoutside of the primaryturbo.jsonreading logic and intoTaskAccessconfiglayering happens instead of ordering them from least to most significant and always choosing a present value, we now go from most to least significant and only choose a value if we do not already have a value for it. This is necessary as we now have a config option (TURBO_ROOT_TURBO_JSON) that alters a less significant config source (turbo.json).config.rsturbo.jsonwe read after partial evaluation of config sourcesTesting Instructions
Existing unit tests for the refactors.
Manual testing of the traced config logic.
Integration test for new feature.