Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(affected): include dependents in affected filter #9137

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(affected): include dependents in affected filter #9137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/turborepo-lib/src/run/scope/filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ impl<'a, T: GitChangeDetector> FilterResolver<'a, T> {
include_uncommitted: true,
allow_unknown_objects: true,
}),
include_dependents: true,
..Default::default()
});
}
Expand Down
19 changes: 19 additions & 0 deletions turborepo-tests/integration/tests/affected-rdeps.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
Setup
$ . ${TESTDIR}/../../helpers/setup_integration_test.sh

Create a new branch
$ git checkout -b my-branch
Switched to a new branch 'my-branch'

Edit a file that affects `util` package
$ echo "foo" >> packages/util/index.js
Commit the change
$ git add .
$ git commit -m "add foo" --quiet

Validate that we run `util#build` and all rdeps
$ ${TURBO} run build --affected --dry=json | jq '.tasks | map(select(.command != "<NONEXISTENT>")) | map(.taskId)| sort'
[
"my-app#build",
"util#build"
]
Loading