chore(watch): simplify watch data synchronization #9154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic view of the futures involved with running
watch
events_fut
takes events from the package changes watcher and folds them into aChangedPackages
struct. It then triggers a notify.run_fut
loops waiting for a notification and then performing a run.SIGINT
sThis PR cleans up how packages changes are synchronized between futures:
RefCell
asMutex
already implies mutually exclusive access the the underlying resourcerun_fut
holding onto the changed packages lock for the entirety of it's run. This allows us to switch fromtokio::sync::Mutex
tostd::sync::Mutex
. Which is suggested by thetokio::sync::Mutex
docsTesting Instructions
rustc
+ 👀 . Quick gut check by runningturbo watch
and triggering package changes