Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log::debug and ignore on daemon usage in CI #9237

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Oct 8, 2024

Setting daemon: true in turbo.json can cause timing out on deploys. Using the daemon in CI/CD is almost* never the desired behavior. Instead, we will detect a CI environment and force the daemon off in these situations.

*perhaps the only use-case is for us, internally, testing the daemon in our internal tests (which, run on the CI).

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:37pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:37pm

@turbo-orchestrator turbo-orchestrator bot added the area: docs Improvements or additions to documentation label Oct 9, 2024
@dimitropoulos dimitropoulos marked this pull request as ready for review October 9, 2024 17:33
@dimitropoulos dimitropoulos changed the title [WIP] warn and ignore on daemon usage in CI warn and ignore on daemon usage in CI Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Hi there 👋

It looks like this PR introduces broken links to the docs, please take a moment to fix them before merging:

Broken link Type File
/repo/docs/guides/tools/typescript#you-likely-dont-need-a-tsconfigjson-file-in-the-root-of-your-project hash /repo-docs/crafting-your-repository/structuring-a-repository.mdx
#package-entrypoint-wildcards hash /repo-docs/guides/tools/typescript.mdx
#package-entrypoint-wildcards hash /repo-docs/guides/tools/typescript.mdx

Thank you 🙏

docs/repo-docs/reference/configuration.mdx Outdated Show resolved Hide resolved
crates/turborepo-lib/src/config/mod.rs Outdated Show resolved Hide resolved
@dimitropoulos dimitropoulos enabled auto-merge (squash) October 9, 2024 18:36
@dimitropoulos dimitropoulos merged commit 278d24e into main Oct 9, 2024
43 of 44 checks passed
@dimitropoulos dimitropoulos deleted the dimitri/ci-daemon branch October 9, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation created-by: turborepo owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants