Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu music not playing when returning to menu #45

Open
verhoevenv opened this issue Apr 28, 2015 · 1 comment
Open

Menu music not playing when returning to menu #45

verhoevenv opened this issue Apr 28, 2015 · 1 comment

Comments

@verhoevenv
Copy link
Owner

I suspect the intention was to make the menu music play whenever the menu is shown, however there's a bug in that code:
at

SwapSourceFilter("music/menu/menu.mp3");

SwapSourceFilter("music/menu/menu.mp3");

references an unknown file, it should be

SwapSourceFilter("music/menu.mp3");
@Enet4
Copy link
Contributor

Enet4 commented Apr 29, 2015

I would prefer moving any hard-coded file names like those into a single place. And the fact that we're calling a function called "SwapSourceFilter" in the main file doesn't comfort me either. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants