Increase read buffer to reduce total syscalls #2772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reduces read syscalls by 96%.
strace
showed that we were doing small incremental reads of large files:This might have been fine 20 years ago, but we can modernize it. Increasing the buffer size reduces the total number of syscalls, which helps in scale-out scenarios with many copies of vpr running on the same system. With this patch, strace looks like:
Another win comes with in libblifparse, which is reading in large blif files. I was able to modify my generated yacc output, however I cannot figure out the correct way to capture this upstream in the build:
Just set all the buffer sizes to 1MB, not sure why ia64 has to be different.