Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn On Choke Point By Default #2777

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Turn On Choke Point By Default #2777

merged 7 commits into from
Oct 18, 2024

Conversation

amin1377
Copy link
Contributor

@amin1377 amin1377 commented Oct 16, 2024 •
edited
Loading

This PR addresses Issue #2750

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code labels Oct 16, 2024
vaughnbetz
vaughnbetz approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I'll file an issue to optimize the time & memory footprint of building the choke point data structures.

@vaughnbetz vaughnbetz changed the title Turn On Choke Point By Default [WIP] Turn On Choke Point By Default Oct 18, 2024
@vaughnbetz vaughnbetz merged commit 8dd84f0 into master Oct 18, 2024
37 of 53 checks passed
@vaughnbetz vaughnbetz deleted the turn_on_choke_point branch October 18, 2024 14:40
@vaughnbetz vaughnbetz mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amin1377 @vaughnbetz