Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add knative-eventing-tutorial example #251

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Add knative-eventing-tutorial example #251

merged 1 commit into from
Jun 8, 2021

Conversation

boramalper
Copy link
Contributor

Work in progress, as I am debugging an obscure error that I encountered only today (not yesterday or the day before...)

In the meanwhile, you may review the code and the respective wiki page. I abstained from copy-pasting the code to the wiki as code changes often, but I'll add a pointer to here instead.

Signed-off-by: Bora M. Alper [email protected]

@boramalper boramalper added the documentation Improvements or additions to documentation label May 28, 2021
ustiugov
ustiugov requested changes May 28, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by boramalper
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good progress!

  • use the default namespace instead of bora-namespace
  • avoid comments that look to similar to the code itself (i.e., if code is readable enough no need for comments)
  • add copyrights to all files

let us leave this "tutorial" in examples/. However, let's have a simplofoed eventing-based chain in function-image/test/function-chain-eventing. That chain should be: client sends an HTTP request -> F1 (producer) that produces an event -> F2 (consumer) that just logs the pipeline completion. In that example, please use the same terminology (chain, producer, consumer, etc.) as in Mike's PR.

however, it would make sense to finish the tutorial first, then send the "test" in another PR. only the test requires adding to the CI.

examples/knative-eventing-tutorial/Dockerfile Outdated Show resolved Hide resolved
examples/knative-eventing-tutorial/go.mod Show resolved Hide resolved
examples/knative-eventing-tutorial/cmd/tempConsumer/main.go Outdated Show resolved Hide resolved
examples/knative-eventing-tutorial/README.md Outdated Show resolved Hide resolved
examples/knative-eventing-tutorial/README.md Outdated Show resolved Hide resolved
examples/knative-eventing-tutorial/Dockerfile Outdated Show resolved Hide resolved
@boramalper boramalper marked this pull request as ready for review May 31, 2021 15:24
@boramalper boramalper mentioned this pull request Jun 2, 2021
Closed
@boramalper boramalper requested a review from ustiugov June 7, 2021 12:05
@boramalper
Copy link
Contributor Author

Now that we have bumped Knative to v0.23, this too is ready to merge.

@boramalper boramalper enabled auto-merge (rebase) June 7, 2021 12:07
@ustiugov ustiugov changed the title Add knative-eventing-tutorial example, work in progress Add knative-eventing-tutorial example Jun 7, 2021
@boramalper
Copy link
Contributor Author

@ustiugov Is there anything else you have requested that I am missing?

ustiugov
ustiugov requested changes Jun 7, 2021
View reviewed changes
examples/knative-eventing-tutorial/Dockerfile Outdated
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

FROM golang:1.16.4-alpine3.13 AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync up with @MBaczun on creating the Golang base image that would be the same across all golang functions

@ustiugov
Copy link
Member

ustiugov commented Jun 7, 2021

apart from the base image, lgtm. great job

ustiugov
ustiugov requested changes Jun 8, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor

examples/knative-eventing-tutorial/Dockerfile Outdated
COPY . ./
RUN make ${target}

FROM vhiveease/golang:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to scratch. for debugging purposes a user can change it back

@ustiugov ustiugov disabled auto-merge June 8, 2021 11:14
@ustiugov
Copy link
Member

ustiugov commented Jun 8, 2021

please add info to the changelog in the Added section

@boramalper
Copy link
Contributor Author

@ustiugov Done.

@ustiugov ustiugov merged commit 92f78ce into vhive-serverless:main Jun 8, 2021
@boramalper boramalper deleted the knative-eventing-tutorial branch June 8, 2021 14:57
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <[email protected]> 1706694164 +0800
committer HermioneKT <[email protected]> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBaczun MBaczun MBaczun left review comments

@ustiugov ustiugov ustiugov approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boramalper @ustiugov @MBaczun