Fix capLevelToPlayerSize after hiding player and maintain stable selection when aspect ratio changes #5614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
capLevelToPlayerSize
Why is this Pull Request needed?
Makes cap-level-controller continue to detect player size changes after it has been hidden and shown again.
Also prevents
autoLevelCapping
from bouncing back and forth when aspect ratio changes slightly between renditions because of rounded height values. To repro set player size to 426px with first BBB test stream.Are there any points in the code the reviewer needs to double check?
The first issue (#5611) can be worked around by toggling capping after displaying the media element again:
This could be done at any time the size/layout of the media element is changed to perform a timely update of
autoLevelCapping
onrequestAnimationFrame
.If you are already using HLS.js in a player that reads/writes page layout and controls the media element and observes its dimensions, then it is recommended to not use cap-level-controller. Instead batch the work of reading player width and height with existing checks in your player, and set
hls.maxAutoLevel
externally.Resolves issues:
Fixes #5611
Checklist