Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mixed sourcebuffer errors #5623

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jul 3, 2023

This PR will...

Handle mixed SourceBuffer append errors, up to appendErrorMaxRetry consecutive errors per SourceBuffer type ('audio', 'video', and 'audiovideo').

Why is this Pull Request needed?

Allows append errors across SourceBuffers until the limit of consecutive errors is reached for a single type. The error count is reset for a particular type after a successful append. This prevents some sequences of append errors from being escalated to fatal, which may be recoverable. This also helps to deal with or identify append errors caused by unsupported mixed segment types, such as unmuxed and muxed 'video' and 'audiovideo' segments (#5369).

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Related to #5369, #1510

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Jul 3, 2023
@robwalch robwalch force-pushed the enhancement/append-errors-per-source-buffer-type branch from 2aeeb42 to 3673ce0 Compare July 4, 2023 00:08
@robwalch robwalch merged commit b71f61d into master Jul 5, 2023
@robwalch robwalch deleted the enhancement/append-errors-per-source-buffer-type branch July 5, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant