Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand isSupported check to allow alternative codecs #6006

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Nov 29, 2023

This PR will...

Why is this Pull Request needed?

Not all platforms support AVC/AAC via MSE.

Applications needing more fine grained support checks based on expected delivery formats can implement those checks in their app layer using isMSESupported and getMediaSource().isTypeSupported(mimeType).

Are there any points in the code the reviewer needs to double check?

Ideally the list of codecs checked will be kept short. It should only contain the most widely supported codecs required for compatibility. Changes can be contributed given specific device or platform specifications that demonstrate the need for such a change.

Resolves issues:

Resolves #6004, #5593

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Add named exports for and expose statically: `isSupported`, `isMSESupported`, and `getMediaSource`
@robwalch robwalch force-pushed the feature/is-supported-codec-expansion branch from e20fa4c to df759ae Compare December 1, 2023 00:37
@robwalch robwalch mentioned this pull request Dec 1, 2023
4 tasks
@robwalch robwalch changed the title Expand isSupported check to test other codecs Expand isSupported check to allow alternative codecs Dec 1, 2023
@robwalch robwalch merged commit fad22f2 into master Dec 5, 2023
15 of 16 checks passed
@robwalch robwalch deleted the feature/is-supported-codec-expansion branch December 5, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant