Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy import statements with linter rules #6378

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

Tidy import statements with linter rules.

Why is this Pull Request needed?

Enforcing consistent type imports is important for differentiating runtime vs TypeScript dependencies in import statements. These rules will help maintain consistent and tidy import statements.

Are there any points in the code the reviewer needs to double check?

  • Added typescript-eslint/consistent-type-imports
  • Added typescript-eslint/no-import-type-side-effects
  • Added typescript-eslint/no-restricted-imports
  • Added import/order and sort-imports rules

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone May 3, 2024
@robwalch robwalch force-pushed the task/consistent-type-imports-and-sorting branch from faf6e5d to 6d0ad85 Compare October 5, 2024 00:01
@robwalch robwalch force-pushed the task/consistent-type-imports-and-sorting branch from 6d0ad85 to f3f76d3 Compare October 8, 2024 03:46
@robwalch robwalch merged commit 2299042 into master Oct 10, 2024
16 checks passed
@robwalch robwalch deleted the task/consistent-type-imports-and-sorting branch October 10, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant