Fix decode error escape in dev #6492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert NALu overflow handling change introduced in #6268 that results in a decode error at 30s w/ https://playertest.longtailvideo.com/adaptive/elephants_dream_v4/media/b2962000-video.m3u8 `PIPELINE_ERROR_DECODE: Error Domain=NSOSStatusErrorDomain Code=-12909 "(null)" (-12909): VTDecompressionOutputCallback`
|
cc @devoldemar (#5847 #4943). These changes need to be reverted because of escapes in existing assets. If you need to address NALu parsing for HEVC in TS in 1.6.0 you will need to provide a compatible fix. |
|
@robwalch |
If incomplete (= malformed) SEI contains some user data this data won't be parsed. It means potential failure of VTT/subtitles playback. Of course, in most cases the risk can be ignored. The test asset from #6268 just does not provide any user data in SEI, at the same time it unveils this problem. |
|
Reproduced on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Revert NALu overflow handling change introduced in #6268 that results in a decode error at 30s w/ https://playertest.longtailvideo.com/adaptive/elephants_dream_v4/media/b2962000-video.m3u8
PIPELINE_ERROR_DECODE: Error Domain=NSOSStatusErrorDomain Code=-12909 "(null)" (-12909): VTDecompressionOutputCallbackWhy is this Pull Request needed?
The above asset produces a decode error when playback reaches 29-30s in Chrome using the latest from dev:
https://hlsjs-dev.video-dev.org/demo/?src=https%3A%2F%2Fbitmovin-a.akamaihd.net%2Fcontent%2Fdataset%2Fmulti-codec%2Fhevc%2Fv720p_ts.m3u8&demoConfig=eyJlbmFibGVTdHJlYW1pbmciOnRydWUsImF1dG9SZWNvdmVyRXJyb3IiOmZhbHNlLCJzdG9wT25TdGFsbCI6ZmFsc2UsImR1bXBmTVA0Ijp0cnVlLCJsZXZlbENhcHBpbmciOi0xLCJsaW1pdE1ldHJpY3MiOi0xfQ==
The escape can be tracked back to #6268.
Are there any points in the code the reviewer needs to double check?
This PR removes the offending changes without removing the test asset added. I don't see how the change makes the test asset play any better - all the segment durations and timestamps show overlap. The change only prevents SEI parsing error logs that have no impact on playback. It doesn't seem like the change was correct - it may have only been adding padding that suppressed those error logs.
Resolves issues:
Checklist