Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vike-vue-unhead #183

Open
brillout opened this issue Aug 15, 2024 · 3 comments
Open

vike-vue-unhead #183

brillout opened this issue Aug 15, 2024 · 3 comments

Comments

@brillout
Copy link
Member

There is already an example of using Vike with vue-unhead here.

It'd be nice to have an extension that automatically integrates vue-unhead.

Curious: with the latest improvements to head management, is there a rationale for using vue-unhead?

@TimJohns
Copy link
Contributor

Thanks - I am out for a week, but will take a look when I get back. I don't know if we need a specific integration for unhead, but going from memory, last time I tried unhead with vikeVue, it was incompatible (or at least not trivial) because the create app hook is called twice (once for the Page and once for the Head), so unhead's state was reset.

@brillout
Copy link
Member Author

because the create app hook is called twice

I guess we can create a flag for this e.g. pageContext.isRenderingHead.

@brillout
Copy link
Member Author

because the create app hook is called twice

I guess we can create a flag for this e.g. pageContext.isRenderingHead.

Done and pre-released as [email protected].

Let me know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants