Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In popstate listener, triggeredBy is misspelled triggedBy #1563

Closed
bravomartin opened this issue Mar 19, 2024 · 3 comments
Closed

In popstate listener, triggeredBy is misspelled triggedBy #1563

bravomartin opened this issue Mar 19, 2024 · 3 comments
Labels

Comments

@bravomartin
Copy link

Description

There is a typo in the code that doesn't match the documentation.

In the popstate event listener, vike adds a custom variable to identify who triggered the event. in the code it's spelled triggedBy, when it should be triggeredBy, as it is correctly spelled in the docs.

@brillout
Copy link
Member

Thanks.

To my knowledge only very few users use this, thus I ain't bumping the major semver even though it's a breaking change.

Released in 0.4.166.

CC @dajinchu

@bravomartin
Copy link
Author

Thanks for such quick reaction! Best

@brillout
Copy link
Member

👍 Btw. in case your company would be up for it: we're looking for sponsors. Sponsoring is making a massive difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants