Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error starting from 0.4.187 #1818

Closed
ktdd opened this issue Aug 20, 2024 · 7 comments
Closed

Build error starting from 0.4.187 #1818

ktdd opened this issue Aug 20, 2024 · 7 comments
Labels

Comments

@ktdd
Copy link

ktdd commented Aug 20, 2024

Description

[[email protected]][Bug] You stumbled upon a Vike bug. Go to https:/vikejs/vike/issues/new and copy-paste this error. A maintainer will fix the bug (usually under 24 hours).
    at isFilePathAbsoluteFilesystem (file:///A:/[REDACTED]/node_modules/vike/dist/esm/utils/isFilePathAbsoluteFilesystem.js:38:13)
    at assertFilePathAbsoluteFilesystem (file:///A:/[REDACTED]/node_modules/vike/dist/esm/utils/isFilePathAbsoluteFilesystem.js:16:12)
    at assertModuleId (file:///A:/[REDACTED]/node_modules/vike/dist/esm/node/plugin/shared/getFilePath.js:133:5)
    at rollupOutput.manualChunks (file:///A:/[REDACTED]/node_modules/vike/dist/esm/node/plugin/plugins/distFileNames.js:53:33)
    at Bundle.assignManualChunks (file:///A:/[REDACTED]/node_modules/rollup/dist/es/shared/node-entry.js:18154:42)
    at Bundle.generateChunks (file:///A:/[REDACTED]/node_modules/rollup/dist/es/shared/node-entry.js:18186:20)
    at Bundle.generate (file:///A:/[REDACTED]/node_modules/rollup/dist/es/shared/node-entry.js:18105:39)
    at file:///A:/[REDACTED]/node_modules/rollup/dist/es/shared/node-entry.js:20661:27

Build is working fine in 0.4.186. Windows 11, TS React project. Let me know if I can provide additional info.

@ktdd ktdd added the bug 💥 label Aug 20, 2024
@brillout
Copy link
Member

Insert the following before line 37 at node_modules/vike/dist/esm/utils/isFilePathAbsoluteFilesystem.js and report back the logs.

        // Ensure isFilePathAbsoluteFilesystem() returns `false` if path is absolute starting from the user root dir (see comments above).
+       console.log('stack', (new Error()).stack);
+       console.log('filePath', filePath);
        if (yes)
            assert(!filePath.startsWith('/'));
        return yes;

@ktdd
Copy link
Author

ktdd commented Aug 20, 2024

stack.txt

@brillout
Copy link
Member

Fix pre-released as 0.4.189-commit-6dfac95, can you confirm it works?

@ktdd
Copy link
Author

ktdd commented Aug 20, 2024

Build runs successfully now, so it seems to be fixed! I'll let you know if I run into problems. Thanks!

@brillout
Copy link
Member

👍 Btw. in case your company is up for it we're looking for sponsors (#1350). It makes a massive difference to us!

@ktdd
Copy link
Author

ktdd commented Aug 21, 2024

👍 Btw. in case your company is up for it we're looking for sponsors (#1350). It makes a massive difference to us!

I develop (volunteer) software for a non-profit so that they can pinch every penny so unfortunately sponsoring isn't possible. Anyway, I've been using Vike since the early VPS days in my personal projects so I sent at least a little something your way. Keep up the excellent work.

@brillout
Copy link
Member

Thank you @ktdd, I appreciate it 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants