show import errors in dev

[nitedani]

Related: #621

Show helper message in dev.

[brillout]

Neat 💯

How about we wrap viteDevServer.ssrLoadModule(virtualFileIdImportUserCodeServer) instead? I guess that would catch the same exceptions?

As for production, we can catch exceptions thrown by await loadServerBuild(outDir).

We can also catch exceptions thrown by await hookFnCaller() such as React's infamous Warning: React.jsx: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined.. (I wrote a React patch a while ago to make debugging this React error much easier; I'll see if I can find it again and polish it.)

[nitedani]

viteDevServer.ssrLoadModule
doesn't throw any errors

I've found no other way to catch these errors.

[brillout]

In principle, the error must/should be catched somewhere by Vike, otherwise Vike wouldn’t be able to show the error page. In other words: if the error leads to the error page to be rendered then we have, de facto, the opportunity to catch the error in Vike Land. (Although make sure the error page exists, otherwise Vike has no error page to render.)

…

On Fri 15. Dec 2023 at 16:19, nitedani ***@***.***> wrote: viteDevServer.ssrLoadModule <https:/vikejs/vike/blob/9a3ac5afc806701af3aee467674c74cd5e0acb89/vike/node/runtime/page-files/setup.ts#L13> doesn't throw any errors I've found no other way to catch these errors. — Reply to this email directly, view it on GitHub <#1358 (comment)>, or unsubscribe <https:/notifications/unsubscribe-auth/AAHVQRRO4CFCNDRO2MT4STLYJRTABAVCNFSM6AAAAABAV2CLTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGA2DOMZSGE> . You are receiving this because you commented.Message ID: ***@***.***>

[brillout]

Notable changes:

• df9423b
• 52a11ca

The rest is mostly just some minor refactoring.

Let me know if you object with any of the changes, otherwise I'll merge 🎉

[nitedani]

onRuntimeError is not called, it stops here: https:/vikejs/vike/pull/1358/files#diff-7fb721f8b206cd2db4fc64bbf0c4e005aac41836d50d66133acc17b019255d1cR114

[brillout]

I actually realized I forgot to try my changes 😅

onRuntimeError is not called, it stops here: https:/vikejs/vike/pull/1358/files#diff-7fb721f8b206cd2db4fc64bbf0c4e005aac41836d50d66133acc17b019255d1cR114

Let me have a look.

[brillout]

I just had a quick look. Vike treats the error as transpilation error and thus doesn't trigger onRuntimeError(). Let me fix this.