Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Data.List functions are nondestructive #592

Closed
tyru opened this issue Jun 11, 2018 · 2 comments
Closed

Ensure Data.List functions are nondestructive #592

tyru opened this issue Jun 11, 2018 · 2 comments

Comments

@tyru
Copy link
Member

tyru commented Jun 11, 2018

via #511 (comment) (thanks @Milly)

  • Remove unnecessary copy() from test files
  • Add tests to check if functions are nondestructive
  • Remove unnecessary copy() from document
  • Note all functions are nondestructive in the document
    • Data.List.uniq(), uniq_by() are noted already
    • Is it enough to note all functions are nondestructive in introduction section?
@ujihisa
Copy link
Member

ujihisa commented Jun 19, 2018

Since existing Data.List functions are not necessarily nondestructive, I'll clarify destructive/nondestructive for each functions in the documentation, as the first step.

@ujihisa
Copy link
Member

ujihisa commented Jan 3, 2019

According to the comment we aren't changing Data.List entirely to non-destructive. Since all the functions with {list} argument clearly mention if they are destructive or non-destructive, I close this now.

@ujihisa ujihisa closed this as completed Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants