-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Locale.Message tests #584
Conversation
hmm, I think @thinca is more appropriate reviewer... (Locale.Message's author) |
Assigned this to @thinca |
@thinca
AFTER:
This explains the benefit |
|
* Check if ja_JP.UTF-8 is available before running each test
Sounds good. Added ffc5fa5 to do that. |
We can also check |
Sounds even better. Added 3fed30c to do that! |
モジュール名変わってる。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
あ、コミットメッセージ…一応直したらマージしてもらえると 🙏 |
Oops, I didn't notice that. Thanks @thinca! fixed. |
🎉🎉🎉 |
🎉🎉🎉 |
4 tests were in pending. I fixed them and made sure all of them passed.