-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Filepath: Refactor is_windows with more documented #589
Conversation
" This is tricky. has('win32') is actually enough, and you don't need | ||
" has('win16') || has('win32') || has('win64') || has('win95') | ||
" to tell if it's windows. | ||
" * has('win16') does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not exist
より was removed
の方が昔はあった事が分かるので良さそう?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! 888f750 で、両方書いてみました (現在存在しないという事実をまず明示的に表明して、その後補足的に歴史を書く流れで)
win95 やその他いにしえの feature については vim_dev の議論の結果によって変わってくるので言及してません。 派生元コメント: |
本当はこの手の環境をチェックする機能(変数)のみを提供するモジュールを用意したい。 |
https://groups.google.com/forum/#!msg/vim_dev/owxmPRf_Pog/plmWQZLSBQAJ
|
" This is tricky. has('win32') is actually enough, and you don't need | ||
" has('win16') || has('win32') || has('win64') || has('win95') | ||
" to tell if it's windows. | ||
" * has('win16') does not exist; it's been removed in the past. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has('win16') and has('win95') do not exist
他のモジュールも合わせてやってもらった方がいいかなと考えたんですが、
|
既存の仕組みに乗っかるなら 2 が一番手っ取り早いかもしれません。 意見募集。 |
github wikiに英語で書いて、
の良さそう tyru++ |
一日ぐらい待って、特に意見なければ wiki にまとめる方針で行きたいと思います… |
期待. 他のモジュールのやつもあとで別pullreqでまとめてやるの先につくっときます。 |
作りました。本pullreqとこのpullreqは独立してreview/merge可能です |
👏 |
No description provided.