Deprecate Text.Sexp #591
Merged
Deprecate Text.Sexp #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `git mv autoload/vital/__vital__/Text/* autoload/vital/__vital__/Deprecated/Text/` * `git mv doc/vital/Text/Sexp.txt doc/vital/Deprecated/Text/Sexp.txt` * `git mv test/Text/Sexp.vim test/Deprecated/Text/Sexp.vim`
tyru
previously requested changes
Jun 11, 2018
doc/vital.txt
Outdated
| @@ -209,7 +209,7 @@ LINKS *Vital-links* | |||
| |vital/Text/LTSV.txt| LTSV library. | |||
| |vital/Text/Lexer.txt| lexer library. | |||
| |vital/Text/Parser.txt| parser library. | |||
| |vital/Text/Sexp.txt| S-Expression parser. | |||
| |vital/Deprecated.Text.Sexp.txt| S-Expression parser. | |||
There was a problem hiding this comment.
ウギャー一斉置換したときにがばっとミスってました。あぶなすぎる
README.md
Outdated
| @@ -77,7 +77,7 @@ Module | Description | |||
| [Text.LTSV](doc/vital/Text/LTSV.txt) | LTSV library | |||
| [Text.Lexer](doc/vital/Text/Lexer.txt) | lexer library | |||
| [Text.Parser](doc/vital/Text/Parser.txt) | parser library | |||
| [Text.Sexp](doc/vital/Text/Sexp.txt) | S-Expression parser | |||
| [Deprecated.Text.Sexp](doc/vital/Deprecated.Text.Sexp.txt) | S-Expression parser | |||
doc/vital/Deprecated/Text/Sexp.txt
Outdated
| @@ -1,27 +1,27 @@ | |||
| *vital/Text/Sexp.txt* S-Expression parser. | |||
| *vital/Deprecated.Text.Sexp.txt* S-Expression parser. | |||
thinca
previously requested changes
Jun 11, 2018
README.md
Outdated
| @@ -77,7 +77,7 @@ Module | Description | |||
| [Text.LTSV](doc/vital/Text/LTSV.txt) | LTSV library | |||
| [Text.Lexer](doc/vital/Text/Lexer.txt) | lexer library | |||
| [Text.Parser](doc/vital/Text/Parser.txt) | parser library | |||
| [Text.Sexp](doc/vital/Text/Sexp.txt) | S-Expression parser | |||
| [Deprecated.Text.Sexp](doc/vital/Deprecated/Text/Sexp.txt) | S-Expression parser | |||
There was a problem hiding this comment.
Deprecated 名前空間以下のモジュールは現状 README や doc/vital.txt のモジュール一覧に記載されていないので、合わせた方が良いかと。
There was a problem hiding this comment.
True. Fixed at 949f6ed. thx!
rhysd
reviewed
Jun 12, 2018
|
|
||
| *Vital.Text.Sexp* is a S-Expression parsing library. For performance it uses | ||
| *Vital.Deprecated.Text.Sexp* is a S-Expression parsing library. For performance it uses | ||
| lua, so the Vim that runs this needs |+lua|. |
There was a problem hiding this comment.
How about adding a notation that this module was deprecated? (though it's obvious from its module name...)
There was a problem hiding this comment.
That's also an option, but I feel that it's verbose to repeat there. (Alternative option would be to insert warning message when you use, but before that the plugin author need to rename the module, so it's still verbose)
rhysd
approved these changes
Jun 12, 2018
tyru
added a commit
that referenced
this pull request
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #587 (comment)