Enable a way to provide a custom configured Tus library. #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the ability to provide a TusClient factory to the Vimeo client. When performing an upload action the factory is used to create a TusClient instead of having a tus client created directly in a private method.
The developer if wanting to inject their own factory would need to implement the factory interface provided in this PR and pass into the Vimeo client constructor.
This allows customization of the
TusClient
by users of the Vimeo api client. For example, the default caching behavior of the TusClient library is a FileStore that creates temporary files within the vendor include directory. In my case, it is not desirable to allow write access to that directory from php runtime.Example use:
Then, where I create a Vimeo client:
A default implementation that does what the library did before has been implemented and is utilized when the developer does not provide it to the constructor.