Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using markdown comments throws NotImplementedError #82

Closed
TymekDev opened this issue Sep 5, 2020 · 2 comments · Fixed by #84
Closed

Using markdown comments throws NotImplementedError #82

TymekDev opened this issue Sep 5, 2020 · 2 comments · Fixed by #84
Labels
bug Something isn't working

Comments

@TymekDev
Copy link
Contributor

TymekDev commented Sep 5, 2020

Describe the bug
Using markdown comment throws NotImplementedError. I suspect this is due to the present using these comments as part of it's syntax (for effects and coloring).

To Reproduce
Add a markdown comment (<!-- comment text here -->) to slides file.

Expected behavior
Either not throwing an NotImplementedError exception or throwing a more descriptive one (e.g. informing that comments not being supported).

Slides

# Markdown Comments Test

Text before comment.

<!-- A markdown comment. -->

Text after comment.

Environment

  • OS: Ubuntu 20.04.1 LTS
  • Terminal emulator: kitty
  • Python version: 3.8.2
  • present version: 0.5.1

Additional context
A solution for this could be differentiating between a regular comment and present syntax. For example <!-- effect=explosions --> could be a regular comment and <!-- [present] effect=explosions --> could be present syntax.

@vinayak-mehta
Copy link
Owner

Thanks for reporting this!

@vinayak-mehta
Copy link
Owner

I think all comments can be skipped. Though the style will be applied if a comment has effects and colors in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants