[MRG] Allow Slideshow to be used as a context manager #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add __enter__ and __exit__ methods. This required re-ordering some of the initialisation of Slideshow, so that the Screen object isn't created until __enter__ is called
|
@clint-lawrence Thanks for looking into and fixing this! This re-ordering makes much more sense. |
vinayak-mehta
changed the title
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enter and exit methods. This required re-ordering
some of the initialisation of Slideshow, so that the Screen
object isn't created until enter is called
This makes cleaning up the terminal state more reliable and
removes the need for the os.system() call to reset.