Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Investigate why config.yaml packaging is working #18

Open
vineetbansal opened this issue Nov 29, 2023 · 1 comment
Open

Investigate why config.yaml packaging is working #18

vineetbansal opened this issue Nov 29, 2023 · 1 comment
Assignees

Comments

@vineetbansal
Copy link
Owner

Original thread:

I meant that when we went through the exercise of how to include arbitrary files in your package when doing a pip install, in this case:

[tool.setuptools.package-data]
wbi = ["data/*"]

There's nothing here that tells setuptools that config.yaml needs to be included. Yet it needs to be (since all wbi configuration would go in there) and it seems to be (since tests are passing), so I'm wondering why it's being included without us specifying it, or maybe somehow we're not testing the functionality against the installed version of wbi.

Originally posted by @vineetbansal in #5 (comment)

@vineetbansal
Copy link
Owner Author

Looks like setuptools-scm is packaging up everything under git in the sdist (wheels are fine). See issue here.

Note from Henry:

You can always exclude everything in the first line of the MANIFEST.in,
then include just what you want. check-sdist or check-manifest can check for you.

For now the sdist is getting bloated with all the matlab/ and other scm folders. We need a long term solution for this. PR #21 fixes this for the short term.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant