Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactor + comments #105

Conversation

a-moreira
Copy link
Collaborator

@a-moreira a-moreira commented Dec 5, 2023

Just a small refactor.

  • renaming Peer -> Client to make it clearer that connections come to our (electrum) Server.
  • removing unnecessary Option<T>

@a-moreira a-moreira marked this pull request as draft December 5, 2023 16:04
@a-moreira a-moreira marked this pull request as ready for review December 14, 2023 04:05
@a-moreira a-moreira changed the title [WIP] small refactor + comments small refactor + comments Dec 14, 2023
@a-moreira a-moreira force-pushed the refactor/floresta-electrum/small-refactor branch from cb12740 to 77fda22 Compare December 14, 2023 15:26
@Davidson-Souza
Copy link
Collaborator

Apart from those two nits, lgtm.

@a-moreira
Copy link
Collaborator Author

just one more small change, from client_loop to client_broker_loop to make it clear that this loop deals with clients requets/messages.

@a-moreira a-moreira merged commit 51ee084 into vinteumorg:master Dec 15, 2023
11 checks passed
@a-moreira a-moreira deleted the refactor/floresta-electrum/small-refactor branch December 15, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants