Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes linting error #139

Closed
wants to merge 1 commit into from
Closed

fixes linting error #139

wants to merge 1 commit into from

Conversation

OsauravO
Copy link
Contributor

@OsauravO OsauravO commented Apr 8, 2024

  • Fixes issue CI: Fix the linting error #138
  • Allowed the fields which are not used currently but will be used in future in florestad/src/config_file.rs which were causing the linting errors.

@a-moreira
Copy link
Collaborator

a-moreira commented Apr 8, 2024

@OsauravO why are these binary files added to the codebase? Why add #[allow(dead_code)] guards to these structs?

@OsauravO
Copy link
Contributor Author

OsauravO commented Apr 8, 2024

The binary files were created when i ran the cargo test and cargo clippy. The fields in these structs are causing the clippy linting errors as they are not used currently. But I thought in future they will be needed, so temporarily to solve that i added these guards. Or if i got something wrong? @a-moreira

@a-moreira a-moreira self-requested a review April 8, 2024 19:10
@Davidson-Souza
Copy link
Collaborator

You shouldn't commit to those binary files. They are simply used by some tests that create a florestad.

Also, just remove the options related to the cli chain provider, I think it's not used anywhere.

@OsauravO OsauravO closed this by deleting the head repository Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants