fix an incompatibility between our implementation of is_unpendable and utreexo's #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lla-dane
added a commit
to lla-dane/Floresta
that referenced
this pull request
Jun 21, 2024
Removed redundant code Added unit tests in floresta-watch-only Added functional tests for Electrum removed redundant code update tests updated tests updated tests Cache headers on ibd (vinteumorg#169) * stop re-openning the bucket every time we do some operation * cache headers for some time before writing to disk * do the same for the block index fix an incompatibility between our implementation of is_unpendable and utreexod's (vinteumorg#170) bump rustreexo (vinteumorg#171) feat: add experimental blockchain.scriptpubkey (vinteumorg#173) Those endpoints aren't part of the upstream yet, but they improve the UX of floresta and other index-less electrum servers like EPS. Floresta doesn't keep a full index of all addresses that ever received sats, as this would take multiple GBs. As a result, users can't ask for arbitrary addresses on-demand. However, with BIP157 client-side filters we can rescan for and address in a relatively efficient way. However, by BIP158 compact block filters, we can't use the Electrum out-of-the-box because they index the scriptpubkey, not script hashes like electrum does. With this endpoint, rather than sending the scripthash, we send the actual scriptpubkey. With the script, we can use BIP158 filters to find transactions belonging to a given address. The endpoints are just all endpoints from `blockchain.scripthash` but taking a scriptpubkey rather than the script hash. They behave identically otherwise. improve stability on ibd (vinteumorg#174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.