Added tests in github workflows and updated makefile #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/verify.yml
Outdated
| uses: actions/[email protected] | ||
|
|
||
| - id: get-version | ||
| run: echo "::set-output name=CURRENT_VERSION::$(cat Makefile | head -n1|awk -F= '{print $2}')" |
There was a problem hiding this comment.
head -n1 won't retrieve the version number anymore since SHELL=bash was added to the Makefile. Recommend replacing it with the below to grab the VERSION regardless of its position
run: |
VERSION=$(grep '^VERSION=' Makefile | awk -F= '{print $2}')
echo "::set-output name=CURRENT_VERSION::$VERSION"
There was a problem hiding this comment.
Yes thats right. updated the code to grab the version from the makefile properly.
arpit4ever
requested changes
May 23, 2024
Updated the Make file and now tests working fine |
Aravindh-Raju
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
testsin github actions workflowsMakefilebased on the updated vinyldns-api containers.