Skip to content

Commit

Permalink
added yarn lockfile for yarn support
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew E. Rhyne committed Oct 27, 2016
1 parent 061b4a5 commit 5b1e1da
Showing 1 changed file with 977 additions and 0 deletions.
Loading

7 comments on commit 5b1e1da

@fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented on 5b1e1da Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library should not contains lockfile.

@thebigredgeek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn recommends it actually https://yarnpkg.com/en/docs/migrating-from-npm

@TooTallNate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't really talk about the end-application vs. reusable module use-case though. Like the article in #321 mentions, the yarn.lock file is not going to be used in the majority of cases, only for us maintainers of debug while developing, it seems.

@thebigredgeek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah true. I am not sure if Yarn consumes lockfiles for dependencies. I am guessing that will be a feature though.

@thebigredgeek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that, just read the article. See the issue

@freewil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to note that Yarn has published a blog article concerning lockfiles in libraries vs apps since this conversation: https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/

@freewil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related issue, removing yarn.lock: #321

Please sign in to comment.