Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys - Upgrade to latest Flutter #202

Closed
jinyuanqing opened this issue Jan 28, 2023 · 4 comments
Closed

Sys - Upgrade to latest Flutter #202

jinyuanqing opened this issue Jan 28, 2023 · 4 comments
Assignees
Labels
duplicate Already reported or already fixed

Comments

@jinyuanqing
Copy link

**AppData/Local/Pub/Cache/git/visual-editor-6497c03070365acf6707400bb41615ddb6f669d4/lib/main.dart:134:7: Error: The non-abstract class 'VisualEditorState' is missing implementations for these members:

  • TextInputClient.didChangeInputControl
  • TextInputClient.performSelector
    Try to either
  • provide an implementation,
  • inherit an implementation from a superclass or mixin,
  • mark the class as abstract, or
  • provide a 'noSuchMethod' implementation.**

It upgraded flutter yesterday and then reported an error
flutter :3.7.0

@adrian-moisa adrian-moisa changed the title It upgraded flutter yesterday and then reported an error Editor - Upgrade to latest Flutter - It upgraded flutter yesterday and then reported an error Jan 28, 2023
@adrian-moisa
Copy link
Collaborator

adrian-moisa commented Jan 28, 2023

Thank you for reporting the issue! I'm currently at the end of a large refactoring process. I've made numerous changes to improve readability of the code. You can see the changes here #174 . I'll be done with this large set and at the end of the refactor I'll upgrade to Latest Flutter as well. Should be done in a couple of days. Sorry, can't push faster than this. After this large refactor is complete we will start making preparations to release it on pub dev.

@adrian-moisa adrian-moisa changed the title Editor - Upgrade to latest Flutter - It upgraded flutter yesterday and then reported an error Editor - Upgrade to latest Flutter Jan 28, 2023
@jinyuanqing
Copy link
Author

It is recommended that different versions be released. The current way of using git addresses directly makes any changes to the source code unusable for projects that use the editor. This would not be the case if different releases were used

@adrian-moisa
Copy link
Collaborator

Agreed. For sure we will have multiple releases once we go live on pub dev. For now this is impractical since we are still in the stage of intensive refactoring. So at the moment the editor in in so called "live beta".

@adrian-moisa adrian-moisa changed the title Editor - Upgrade to latest Flutter Sys - Upgrade to latest Flutter Sep 6, 2023
@adrian-moisa
Copy link
Collaborator

Fixed in #234. Apologies for the very long delay. I've been in crunch mode and I pushed my Flutter upgrade for half an year.

@adrian-moisa adrian-moisa self-assigned this Sep 6, 2023
@adrian-moisa adrian-moisa added the duplicate Already reported or already fixed label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Already reported or already fixed
Projects
None yet
Development

No branches or pull requests

2 participants