Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys - Remove Tuple package dependency #45

Closed
adrian-moisa opened this issue May 30, 2022 · 2 comments
Closed

Sys - Remove Tuple package dependency #45

adrian-moisa opened this issue May 30, 2022 · 2 comments
Assignees

Comments

@adrian-moisa
Copy link
Collaborator

Atm, there is a dependency to the tuple package which I think should be either removed or should be exposed so visual-editor users won't have to import the tuple package as well. I add to import the package manually to edit the lineSpacing for instance:

quill.VisualEditor(
                customStyles: quill.DefaultStyles(
                    paragraph: quill.DefaultTextBlockStyle(
                  Theme.of(context).textTheme.bodyText2!,
                  const Tuple2(8, 0),
                  const Tuple2(0, 0),
                  null,
                )),
// ....
)

This seems to have been used a lot in the package. However, having a Tuple instead of a concrete class makes the implementation quite obscure. Here for instance, I don't see why the lineSpacing is not a simple double instead of a Tuple.

@sebastian0107
Copy link
Collaborator

When I start working on visual-editor, I had difficulty cloning the repo and running the demo so I made a tutorial to help other users who want to contribute:

  1. Clone the repository using "https:/visual-space/visual-editor.git"
  2. Run flutter pub get and enable dart editor
  3. If you can't run the main.dart you have to change it with the one from example (example is used to run the demo app)
    -> edit configurations -> set the dart entrypoint with: C:*your path*\visual-editor\example\lib\main.dart
  4. To push commits we have to ask the moderator to give you access.

It can be found also in the README.md

@adrian-moisa
Copy link
Collaborator Author

Congrats! Great work on this ticket!

@adrian-moisa adrian-moisa changed the title Remove Tuple package dependency Sys - Remove Tuple package dependency Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants