Add 0 division check so we don't kill the universe

vitalets · Apr 12, 2017 · 1311bc3 · 1311bc3
1 parent c0d38d8
commit 1311bc3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/replacers/__tests__/operation.test.js b/src/replacers/__tests__/operation.test.js
@@ -47,6 +47,8 @@ describe('operation', function () {
  .toThrowError('Unknown operator: a');
  expect(() => operation.exec({operator: '+', v1: '10', v2: 0.5}))
  .toThrowError('Operation value should be number, you try: 10');
+ expect(() => operation.exec({operator: '/', v1: 10, v2: 0}))
+ .toThrowError('Operation divisor should not be zero');
  expect(() => operation.exec({operator: '+', v1: 10, v2: null}))
  .toThrowError('Operation value should be number, you try: null');
  });

diff --git a/src/replacers/operation.js b/src/replacers/operation.js
@@ -39,6 +39,9 @@ function exec(opInfo) {
  assertOperator(opInfo.operator);
  assertValue(opInfo.v1);
  assertValue(opInfo.v2);
+ if (opInfo.operator === '/') {
+ assertDivisor(opInfo.v2);
+ }
  let fn = operators[opInfo.operator];
  return fn(opInfo.v1, opInfo.v2);
 }
@@ -63,3 +66,9 @@ function assertValue(value) {
  throw new Error('Operation value should be number, you try: ' + value);
  }
 }
+
+function assertDivisor(divisor) {
+ if (divisor === 0) {
+ throw new Error('Operation divisor should not be zero');
+ }
+}