Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unpacked sources by default to reduce bundle size in final apps #22

Closed
vitalets opened this issue Nov 8, 2019 · 0 comments
Closed

Comments

@vitalets
Copy link
Owner

vitalets commented Nov 8, 2019

Problem
Currently package.main points to dist/index.js. It means when I build my app with websocket-as-promised - I can get duplicated dependencies (and definitely duplicated webpack-runtime)

Solution

  • point package.main to src/index.js. But build bundle as well. Bundle can be included as require('websocket-as-promised/dist').
  • replace dependency promise-controller (provided also as bundled) with more universal promised-map
  • use rollup as bundler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant