feat: support new React Compiler target option #374
Merged
+80
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteto
changed the title
poteto
added a commit
to facebook/react
that referenced
this pull request
Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address. However `yarn build` and `yarn preview` does work as expected.
poteto
added a commit
to facebook/react
that referenced
this pull request
Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address. However `yarn build` and `yarn preview` does work as expected.
poteto
added a commit
to facebook/react
that referenced
this pull request
Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address. However `yarn build` and `yarn preview` does work as expected.
poteto
added a commit
to facebook/react
that referenced
this pull request
Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address. However `yarn build` and `yarn preview` does work as expected.
ArnaudBarre
reviewed
Oct 10, 2024
React Compiler was updated to accept a [`target` option](facebook/react#31143) and [`runtimeModule` was removed](facebook/react#31145). vite-plugin-react will still detect `runtimeModule` for backwards compatibility.
poteto
added a commit
to facebook/react
that referenced
this pull request
Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address. However `yarn build` and `yarn preview` does work as expected.
poteto
added a commit
to facebook/react
that referenced
this pull request
Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address. However `yarn build` and `yarn preview` does work as expected. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31166). * #31167 * __->__ #31166 * #31165
ArnaudBarre
changed the title
sapphi-red
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Compiler was updated to accept a
targetoption andruntimeModulewas removed. vite-plugin-react will still detectruntimeModulefor backwards compatibility.Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).