Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use import type for type only file import #263

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 10, 2023

Description

This PR fixes the error in ecosystem-ci: https:/vitejs/vite-ecosystem-ci/actions/runs/6401781367/job/17379560146#step:8:460

Vite 5's scanner now crawls dynamic imports with variables.
This line was not working since vitejs/vite#5850 was merged but no error happened because the scanner wasn't crawling this file.
See vitejs/vite#14533 for more details.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 9cce3f9 into main Oct 10, 2023
9 checks passed
@patak-dev patak-dev deleted the chore/workaround-failing-test branch October 10, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants